bug/3141-e2e-failing + nexus integration #3188

andrew-jameson · 2024-09-12T20:26:55Z

Summary of Changes

Pull request closes #3141

How to Test

Ensure codebase has been deployed to tdp-backend-develop
You can wait for the CircleCI test-e2e-deployment pipeline to run
or you can load Cypress locally (also change out cypress URLS) and send tests to develop

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

[insert ACs here]
lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- If this PR introduces backend code changes, are they meaningfully tested?
- If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

Are backend code style checks passing on CircleCI?
Are frontend code style checks passing on CircleCI?
Are code maintainability principles being followed?

Deliverable 4: Accessible

Does this PR complete the epic?
Are links included to any other gov-approved PRs associated with epic?
Does PR include documentation for Raft's a11y review?
Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Does this PR provide background for why coding decisions were made?
If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces dependencies, are their licenses documented?
Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

Does the OWASP Scan pass on CircleCI?
Do manual code review and manual testing detect any new security issues?
If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

the purpose of the research
methods used to conduct the research
who participated in the research
what was tested and how
impact of research on TDP
(if applicable) final design mockups produced for TDP development

…ST to succeed

tdrs-frontend/nginx/cloud.gov/locations.conf

…erer

tdrs-frontend/cypress/support/commands.js

tdrs-frontend/nginx/cloud.gov/locations.conf

andrew-jameson · 2024-09-16T20:31:51Z

tdrs-frontend/nginx/cloud.gov/locations.conf

        proxy_set_header   Host $host;
        proxy_set_header   X-Real-IP         $remote_addr;
        proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;
-        proxy_set_header   X-Forwarded-Proto https;
+        #proxy_set_header   X-Forwarded-Proto https;


Suggested change

#proxy_set_header X-Forwarded-Proto https;

proxy_set_header X-Forwarded-Proto https;

tdrs-backend/tdpservice/settings/common.py

…into bug/3141-e2e-failing

andrew-jameson · 2024-09-18T20:48:37Z

tdrs-frontend/cypress/e2e/accounts/accounts.feature

-    Scenario: A new user is approved and can see the app homepage
+    Scenario: A new user requests access
        Given The admin logs in
        And '[email protected]' is in begin state
        When '[email protected]' visits the home page
        And '[email protected]' logs in
-        Then '[email protected]' requests access
-        And The admin sets the approval status of '[email protected]' to 'Approved'
+        When '[email protected]' requests access
+        Then '[email protected]' sees the request still submitted
+    Scenario: A new user is approved and can see the app homepage
+        Given The admin logs in
+        When '[email protected]' visits the home page
+        Then The admin sets the approval status of '[email protected]' to 'Approved'
+        And '[email protected]' logs in


By splitting this into two scenarios, we are side-stepping some issue with csrf and/or csrfMiddlewaretoken that cypress is not handling for the two users. This was able to get a local cypress pointed at develop to pass tests successfully but leaves technical debt on why the tokenization steps are failing in the back and forth of requests and responses. We were also seeing 302 and then 200 even on failed POSTS/PATCHES indicating there's a flaw in our user code on the django api view.

tdrs-frontend/cypress/e2e/common-steps/common-steps.js

andrew-jameson · 2024-09-18T20:49:39Z

tdrs-frontend/cypress/support/commands.js

      form: true,
      headers: {
-        Referer: `${Cypress.env('adminUrl')}`,
+        Referer: `${Cypress.env('adminUrl')}${path}`,


This is likely not needed by more closely mimics what I see via dev tools in Firefox.

andrew-jameson · 2024-09-18T20:49:50Z

tdrs-frontend/nginx/cloud.gov/locations.conf

@@ -5,6 +5,7 @@ location ~ ^/(v1|admin|static/admin|swagger|redocs) {
        set $backend http://{{env "BACKEND_HOST"}}.apps.internal:8080$request_uri;
        proxy_pass $backend;
        proxy_pass_header x-csrftoken;
+        proxy_set_header Referer {{env "ALLOWED_ORIGIN" }};


Probably un-needed.

tdrs-backend/tdpservice/users/serializers.py

andrew-jameson added 8 commits September 12, 2024 16:24

Nginx change to try forcing Referer in header to be passed for the PO…

fe87c00

…ST to succeed

whitespace to retry

7abf072

update to admin url, still need to deploy to develop

62627d0

reducing workflows, trying nexus for cf

b71eb49

reverting curl, apt working again?

6afd66f

now using nexus for apt

f3f0a04

and pypi is proxying now

500e19f

frontend files

6433984

andrew-jameson commented Sep 13, 2024

View reviewed changes

tdrs-frontend/nginx/cloud.gov/locations.conf Outdated Show resolved Hide resolved

remove host keyword

1bce850

andrew-jameson changed the title ~~Nginx change to try forcing Referer in header to be passed for the PO…~~ bug/3141-e2e-failing Sep 13, 2024

andrew-jameson changed the title ~~bug/3141-e2e-failing~~ bug/3141-e2e-failing + nexus integration Sep 13, 2024

andrew-jameson added 7 commits September 13, 2024 17:56

reversion

112d2f8

break out pass header args

ae7bc25

After testing again in develop, back to nginx changes around this ref…

681f138

…erer

Django docs not lining up, maybe we need this?

4736b15

Trying CORS flag

bae540e

hardcoding referer vs using backend, we think it might be frontend uri

e1a0d24

comment removed

38fbf17

andrew-jameson commented Sep 16, 2024

View reviewed changes

tdrs-frontend/cypress/support/commands.js Outdated Show resolved Hide resolved

andrew-jameson commented Sep 16, 2024

View reviewed changes

tdrs-frontend/nginx/cloud.gov/locations.conf Outdated Show resolved Hide resolved

Apply suggestions from code review

c51e86b

andrew-jameson commented Sep 16, 2024

View reviewed changes

tdrs-backend/tdpservice/settings/common.py Outdated Show resolved Hide resolved

andrew-jameson added 6 commits September 16, 2024 16:39

trying env var in nginx, latest cypress

732e638

Merge branch 'bug/3141-e2e-failing' of github.com:raft-tech/TANF-app …

f2046ea

…into bug/3141-e2e-failing

can this stop the double-deploy?

821636a

trying frontend with a diferent mirror

d0bb36a

syntax nginx change

69f3659

removing duplicative workflows

5f00c42

andrew-jameson and others added 2 commits September 18, 2024 14:50

Merge branch 'develop' into bug/3141-e2e-failing

73eddac

Changes from office hours working session

b431b73

andrew-jameson commented Sep 18, 2024

View reviewed changes

tdrs-frontend/cypress/e2e/common-steps/common-steps.js Outdated Show resolved Hide resolved

andrew-jameson commented Sep 18, 2024

View reviewed changes

tdrs-backend/tdpservice/users/serializers.py Outdated Show resolved Hide resolved

andrew-jameson commented Sep 18, 2024

View reviewed changes

tdrs-backend/tdpservice/users/serializers.py Outdated Show resolved Hide resolved

andrew-jameson and others added 3 commits September 18, 2024 16:52

Clean-up of commented code or incorrect changes/fixes

c2276d3

New lock file

677c45c

npm dependencies fix

6a33333

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug/3141-e2e-failing + nexus integration #3188

bug/3141-e2e-failing + nexus integration #3188

andrew-jameson commented Sep 12, 2024 •

edited

Loading

andrew-jameson Sep 16, 2024

andrew-jameson Sep 18, 2024

andrew-jameson Sep 18, 2024

andrew-jameson Sep 18, 2024

	#proxy_set_header X-Forwarded-Proto https;
	proxy_set_header X-Forwarded-Proto https;

bug/3141-e2e-failing + nexus integration #3188

Are you sure you want to change the base?

bug/3141-e2e-failing + nexus integration #3188

Conversation

andrew-jameson commented Sep 12, 2024 • edited Loading

Summary of Changes

How to Test

Deliverables

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrew-jameson commented Sep 12, 2024 •

edited

Loading